Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Added hackathons section #113

Merged
merged 12 commits into from
Aug 10, 2020
Merged

Added hackathons section #113

merged 12 commits into from
Aug 10, 2020

Conversation

kkkkkabir
Copy link
Contributor

@kkkkkabir kkkkkabir commented Jul 23, 2020 •
edited
Loading

Added a hackathons section.

What does this PR do?

I have added a hackathons section where all the coding contests and competition sites will be displayed.

@kkkkkabir
Update README.md
0819f0a 
Added a useful link to learn javascript in a modern way.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2020
@kkkkkabir kkkkkabir changed the title Added a great javascript tutorial website Added a great javascript tutorial website and a website for amazing hackathons Jul 23, 2020
saranshkataria
saranshkataria reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@saranshkataria saranshkataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devpost isn't really a blog, so I don't think it makes sense in that section and modern way to learn javascript makes more sense in the blogs section since it is a collection of articles, and not one

@kkkkkabir
Copy link
Contributor Author

@saranshkataria Ah! Ok, I got it. Where would Devpost fit in then?

@kkkkkabir kkkkkabir changed the title Added a great javascript tutorial website and a website for amazing hackathons Added a great javascript tutorial website Jul 23, 2020
@saranshkataria
Copy link
Contributor

Not sure. Probably could be a new section for hackathons, or maybe we could rename the "blogs" title to something more generic to incorporate such websites too

@saranshkataria
Copy link
Contributor

Let's rename blogs to websites?

@jordanliu
Copy link
Contributor

jordanliu commented Jul 23, 2020 •
edited
Loading

Not sure. Probably could be a new section for hackathons, or maybe we could rename the "blogs" title to something more generic to incorporate such websites too

+1 for the addition of Hackathons, can help to reduce some of the clutter in other categories.

@kkkkkabir
Copy link
Contributor Author

@saranshkataria I guess having a separate section for hackathons and competitions would be nice; this way the navigation would be clearer and not cluttered in one section.

@saranshkataria
Copy link
Contributor

Sounds good. Let's do it!

@kkkkkabir
Copy link
Contributor Author

Should I create the hackathon section?

@saranshkataria
Copy link
Contributor

Yeah, let's do it as a part of this PR itself

@kkkkkabir kkkkkabir changed the title Added a great javascript tutorial website Added hackathons section Aug 7, 2020
@kkkkkabir
Copy link
Contributor Author

Sorry I was busy for a while. Is the new hackathon section looking good?

@saranshkataria
Copy link
Contributor

Great! Thanks for your contribution!

@saranshkataria saranshkataria merged commit b4de037 into fbdevelopercircles:master Aug 10, 2020
This was referenced Aug 20, 2020
Closed
Closed
This was referenced Aug 20, 2020
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saranshkataria saranshkataria saranshkataria left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkkkkabir @saranshkataria @jordanliu @facebook-github-bot